p36850791
/
kinetic-devel
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

added check for self-dependency, #3526

This commit is contained in:
Brian Gerkey 2011-06-13 03:05:46 +00:00
parent b33cce95a5
commit 380db6bc3b
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/rospack/rospack.cpp
View File

@ -410,6 +410,12 @@ const vector<Package *> &Package::direct_deps(bool missing_package_as_warning)
manifest_path().c_str()); manifest_path().c_str());
throw runtime_error(string("invalid manifest")); throw runtime_error(string("invalid manifest"));
} }
else if(dep_pkgname == name)
{
fprintf(stderr,"[rospack] package [%s] depends on itself (%s).\n",
name.c_str(), manifest_path().c_str());
throw runtime_error(string("self-dependency"));
}
// Must make a copy here, because the call to g_get_pkg() below might // Must make a copy here, because the call to g_get_pkg() below might
// cause a recrawl, which blows aways the accumulated data structure. // cause a recrawl, which blows aways the accumulated data structure.
char* dep_pkgname_copy = strdup(dep_pkgname); char* dep_pkgname_copy = strdup(dep_pkgname);