Remove Basestar from global scope

This commit is contained in:
Andrew Stewart 2014-04-24 16:31:47 -06:00
parent dc09be6bcc
commit a9ae09bdce
4 changed files with 41 additions and 56 deletions

View File

@ -8,7 +8,8 @@
"use strict";
require('./basestar');
var Basestar = require('./basestar');
var namespace = require('node-namespace');
// The Adaptor class is a base class for Adaptor classes in external Cylon
@ -63,5 +64,5 @@ namespace("Cylon", function() {
return Adaptor;
})(Cylon.Basestar);
})(Basestar);
});

View File

@ -17,7 +17,9 @@ var EventEmitter = require('events').EventEmitter;
//
// It also extends EventEmitter, so child classes are capable of emitting events
// for other parts of the system to handle.
var Basestar = function Basestar(opts) {
var Basestar;
module.exports = Basestar = function Basestar(opts) {
this.self = this;
}
@ -98,6 +100,3 @@ Basestar.prototype.defineDriverEvent = function(opts) {
return this.defineEvent(opts);
};
if (!global.Cylon) { global.Cylon = {}; }
module.exports = global.Cylon.Basestar = Basestar;

View File

@ -8,7 +8,8 @@
'use strict';
require('./basestar');
var Basestar = require('./basestar');
var namespace = require('node-namespace');
// The Driver class is a base class for Driver classes in external Cylon
@ -65,5 +66,5 @@ namespace("Cylon", function() {
return Driver;
})(Cylon.Basestar);
})(Basestar);
});

View File

@ -1,13 +1,13 @@
"use strict";
source('basestar');
var Basestar = source('basestar');
var EventEmitter = require('events').EventEmitter;
describe('Basestar', function() {
describe('constructor', function() {
it('assigns @self to the instance of the Basestar class', function() {
var instance = new Cylon.Basestar();
var instance = new Basestar();
expect(instance.self).to.be.eql(instance);
});
});
@ -15,8 +15,7 @@ describe('Basestar', function() {
describe('#proxyMethods', function() {
var methods = ['asString', 'toString', 'returnString'];
var ProxyClass = (function() {
function ProxyClass() {}
var ProxyClass = function ProxyClass() {}
ProxyClass.prototype.asString = function() {
return "[object ProxyClass]";
@ -30,21 +29,12 @@ describe('Basestar', function() {
return string;
};
return ProxyClass;
})();
var TestClass = (function(_super) {
subclass(TestClass, _super);
function TestClass() {
var TestClass = function TestClass() {
this.testInstance = new ProxyClass;
this.proxyMethods(methods, this.testInstance, this, true);
}
return TestClass;
})(Cylon.Basestar);
subclass(TestClass, Basestar);
it('can alias methods', function() {
var testclass = new TestClass;
@ -66,16 +56,10 @@ describe('Basestar', function() {
});
describe("#defineEvent", function() {
var ProxyClass = (function(klass) {
subclass(ProxyClass, klass);
function ProxyClass() {}
return ProxyClass;
})(Cylon.Basestar);
var EmitterClass = (function(klass) {
subclass(EmitterClass, klass);
var ProxyClass = function ProxyClass() {};
function EmitterClass(update) {
var EmitterClass = function EmitterClass(update) {
update || (update = false);
this.proxy = new ProxyClass();
this.defineEvent({
@ -86,8 +70,8 @@ describe('Basestar', function() {
});
}
return EmitterClass;
})(Cylon.Basestar);
subclass(ProxyClass, Basestar);
subclass(EmitterClass, Basestar);
it("proxies events from one class to another", function() {
var eventSpy = spy(),
@ -127,7 +111,7 @@ describe('Basestar', function() {
var basestar;
before(function() {
basestar = new Cylon.Basestar();
basestar = new Basestar();
basestar.connector = new EventEmitter();
basestar.connection = new EventEmitter();
});
@ -159,7 +143,7 @@ describe('Basestar', function() {
var basestar;
before(function() {
basestar = new Cylon.Basestar();
basestar = new Basestar();
basestar.connection = new EventEmitter();
basestar.device = new EventEmitter();
});