From bc4a1f5cea48bb6d9807bda23dbf9f3ab8dd556a Mon Sep 17 00:00:00 2001 From: Andrew Stewart Date: Wed, 4 Jun 2014 16:01:47 -0700 Subject: [PATCH] Remove JSHint/Istanbul from package.json JSHint is very rarely used, and Istanbul only on Travis to generate coverage reports for CodeClimate. So instead of bundling it with Cylon at all times, it will now be installed globally by Travis prior to running tests. The Make tasks for JSHint/Istanbul now also assume both packages are installed globally, rather than in the local node_modules directory. --- .travis.yml | 2 +- Makefile | 8 ++++---- package.json | 4 +--- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/.travis.yml b/.travis.yml index 060300f..8b1a91c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,6 +1,6 @@ language: node_js script: - - npm install -g codeclimate-test-reporter + - npm install -g istanbul codeclimate-test-reporter - make cover - CODECLIMATE_REPO_TOKEN=d3aad610220b6eaf4f51e38393c1b62586b1d68b898b42e418d9c2a8e0a7cb0d codeclimate < coverage/lcov.info node_js: diff --git a/Makefile b/Makefile index cb37c7f..d92b743 100644 --- a/Makefile +++ b/Makefile @@ -8,14 +8,14 @@ VERSION := $(shell node -e "console.log(require('./package.json').version)") test: @$(BIN)/mocha --colors $(TEST_FILES) -cover: - @$(BIN)/istanbul cover $(BIN)/_mocha $(TEST_FILES) --report lcovonly -- -R spec - bdd: @$(BIN)/mocha --colors -R spec $(TEST_FILES) +cover: + @istanbul cover $(BIN)/_mocha $(TEST_FILES) --report lcovonly -- -R spec + lint: - @$(BIN)/jshint ./lib + @jshint ./lib release: @git tag -m "$(VERSION)" v$(VERSION) diff --git a/package.json b/package.json index 7eb03ac..69347d9 100644 --- a/package.json +++ b/package.json @@ -39,9 +39,7 @@ "sinon-chai": "2.5.0", "chai": "1.9.1", "mocha": "1.18.2", - "sinon": "1.9.1", - "jshint": "2.5.0", - "istanbul": "0.2.10" + "sinon": "1.9.1" }, "dependencies": {