p71924506
/
excelize
forked from p30928647/excelize
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

This closes #1229, rename ErrMaxFileNameLength to ErrMaxFilePathLength (#1230) 

Co-authored-by: sceneq
This commit is contained in:
sceneq 2022-05-16 22:05:22 +09:00 committed by GitHub
parent 19a0cf3cec
commit be5a4033c0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
errors.go
View File

@ -109,9 +109,9 @@ var (
// ErrWorkbookExt defined the error message on receive an unsupported // ErrWorkbookExt defined the error message on receive an unsupported
// workbook extension. // workbook extension.
ErrWorkbookExt = errors.New("unsupported workbook extension") ErrWorkbookExt = errors.New("unsupported workbook extension")
// ErrMaxFileNameLength defined the error message on receive the file name // ErrMaxFilePathLength defined the error message on receive the file path
// length overflow. // length overflow.
ErrMaxFileNameLength = errors.New("file name length exceeds maximum limit") ErrMaxFilePathLength = errors.New("file path length exceeds maximum limit")
// ErrEncrypt defined the error message on encryption spreadsheet. // ErrEncrypt defined the error message on encryption spreadsheet.
ErrEncrypt = errors.New("not support encryption currently") ErrEncrypt = errors.New("not support encryption currently")
// ErrUnknownEncryptMechanism defined the error message on unsupported // ErrUnknownEncryptMechanism defined the error message on unsupported

2
excelize_test.go
View File

@ -170,7 +170,7 @@ func TestOpenFile(t *testing.T) {
assert.NoError(t, f.SetCellStr("Sheet2", "c"+strconv.Itoa(i), strconv.Itoa(i))) assert.NoError(t, f.SetCellStr("Sheet2", "c"+strconv.Itoa(i), strconv.Itoa(i)))
} }
assert.NoError(t, f.SaveAs(filepath.Join("test", "TestOpenFile.xlsx"))) assert.NoError(t, f.SaveAs(filepath.Join("test", "TestOpenFile.xlsx")))
assert.EqualError(t, f.SaveAs(filepath.Join("test", strings.Repeat("c", 199), ".xlsx")), ErrMaxFileNameLength.Error()) assert.EqualError(t, f.SaveAs(filepath.Join("test", strings.Repeat("c", 199), ".xlsx")), ErrMaxFilePathLength.Error())
assert.NoError(t, f.Close()) assert.NoError(t, f.Close())
} }

4
file.go
View File

@ -66,8 +66,8 @@ func (f *File) Save() error {
// SaveAs provides a function to create or update to a spreadsheet at the // SaveAs provides a function to create or update to a spreadsheet at the
// provided path. // provided path.
func (f *File) SaveAs(name string, opt ...Options) error { func (f *File) SaveAs(name string, opt ...Options) error {
if len(name) > MaxFileNameLength { if len(name) > MaxFilePathLength {
return ErrMaxFileNameLength return ErrMaxFilePathLength
} }
f.Path = name f.Path = name
contentType, ok := map[string]string{ contentType, ok := map[string]string{

2
xmlDrawing.go
View File

@ -103,7 +103,7 @@ const (
StreamChunkSize = 1 << 24 StreamChunkSize = 1 << 24
MaxFontFamilyLength = 31 MaxFontFamilyLength = 31
MaxFontSize = 409 MaxFontSize = 409
MaxFileNameLength = 207 MaxFilePathLength = 207
MaxFieldLength = 255 MaxFieldLength = 255
MaxColumnWidth = 255 MaxColumnWidth = 255
MaxRowHeight = 409 MaxRowHeight = 409