p71924506
/
excelize
forked from p30928647/excelize
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

This avoid unnecessary byte/string conversion (#1541) 

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This commit is contained in:
Eng Zer Jun 2023-05-22 09:24:28 +08:00 committed by GitHub
parent a246db6a40
commit c232748400
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
numfmt.go
View File

@ -1220,7 +1220,7 @@ func printCommaSep(text string) string {
if i > 0 && (length-i)%3 == 0 { if i > 0 && (length-i)%3 == 0 {
target.WriteString(",") target.WriteString(",")
} }
target.WriteString(string(text[i])) target.WriteByte(text[i])
} }
if len(subStr) == 2 { if len(subStr) == 2 {
target.WriteString(".") target.WriteString(".")

6
table.go
View File

@ -490,7 +490,7 @@ func (f *File) parseFilterExpression(expression string, tokens []string) ([]int,
// expressions). // expressions).
conditional := 0 conditional := 0
c := tokens[3] c := tokens[3]
if conditionFormat.Match([]byte(c)) { if conditionFormat.MatchString(c) {
conditional = 1 conditional = 1
} }
expression1, token1, err := f.parseFilterTokens(expression, tokens[:3]) expression1, token1, err := f.parseFilterTokens(expression, tokens[:3])
@ -538,7 +538,7 @@ func (f *File) parseFilterTokens(expression string, tokens []string) ([]int, str
} }
token := tokens[2] token := tokens[2]
// Special handling for Blanks/NonBlanks. // Special handling for Blanks/NonBlanks.
re := blankFormat.Match([]byte(strings.ToLower(token))) re := blankFormat.MatchString((strings.ToLower(token)))
if re { if re {
// Only allow Equals or NotEqual in this context. // Only allow Equals or NotEqual in this context.
if operator != 2 && operator != 5 { if operator != 2 && operator != 5 {
@ -563,7 +563,7 @@ func (f *File) parseFilterTokens(expression string, tokens []string) ([]int, str
} }
// If the string token contains an Excel match character then change the // If the string token contains an Excel match character then change the
// operator type to indicate a non "simple" equality. // operator type to indicate a non "simple" equality.
re = matchFormat.Match([]byte(token)) re = matchFormat.MatchString(token)
if operator == 2 && re { if operator == 2 && re {
operator = 22 operator = 22
} }