p71924506
/
excelize
forked from p30928647/excelize
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
364 Commits 2 Branches 0 Tags 6.5 MiB
Commit Graph

26 Commits

Author SHA1 Message Date
Veniamin Albaev dc01264562 Huge refactorig for consistent col/row numbering (#356) 
* Huge refactorig for consistent col/row numbering

Started from simply changing ToALphaString()/TitleToNumber() logic and related fixes.
But have to go deeper, do fixes, after do related fixes and again and again.

Major improvements:

1. Tests made stronger again (But still be weak).
2. "Empty" returns for incorrect input replaces with panic.
3. Check for correct col/row/cell naming & addressing by default.
4. Removed huge amount of duplicated code.
5. Removed ToALphaString(), TitleToNumber() and it helpers functions at all,
and replaced with SplitCellName(), JoinCellName(), ColumnNameToNumber(), ColumnNumberToName(), CellNameToCoordinates(), CoordinatesToCellName().
6. Minor fixes for internal variable naming for code readability (ex. col, row for input params, colIdx, rowIdx for slice indexes etc).

* Formatting fixes
 2019-03-20 00:14:41 +08:00
xuri f66212da9b
Resolve #106, #294 performance optimization for add hyperlink 2019-02-26 14:21:44 +08:00
xuri 1aed1d744b
Resolve #274, performance optimization for add images, charts and shapes 2019-02-25 22:14:34 +08:00
BluesJhao 1427027e38 Resolve #235, performance optimization for add comments (#347) 2019-02-25 00:29:58 +08:00
xuri c223815cfe
Resolve #345, get comments by target reference 2019-02-23 16:20:44 +08:00
xuri fabd9d013f
README updated 2019-01-01 13:20:14 +08:00
xuri 90bdd3632f
Fix the issue caused by missing tradition to strict conversion for `sharedStringsReader()`, relate issue #276 2018-10-18 10:23:08 +08:00
xuri 3e004d900b
Comments style changed. 2018-09-14 00:58:48 +08:00
xuri 13a9769cc5
Comments style changed. 2018-09-14 00:44:23 +08:00
xuri 2f146c923c
Comments style changed. 2018-09-14 00:35:47 +08:00
xuri 6ced438f39
New function `AddPictureFromBytes()` has been added, this resolve #259 and close #271. 2018-09-14 00:24:49 +08:00
xuri b4a6e61ec3
Fix golint errors under confidence 0.1 2018-09-12 15:47:56 +08:00
xuri ec37b114c3
Fixes #256 and format document. 2018-08-06 10:21:24 +08:00
xuri a3571ee39b
Bugfix: create worksheet cause file issue. Relate issue #249. 2018-07-17 15:28:22 +08:00
xuri 79dfe1c307
GoDoc updated. 2018-07-13 17:40:47 +08:00
Rad Cirskis e3050d21e7 added retieval of worksheet comments 2018-06-30 22:37:14 +12:00
xuri 74c6091cfc
Update comment.go 
make the comment box's height auto and having the minimum height.
 2018-06-28 10:03:53 +08:00
Rad Cirskis 741810a863 improved commenting formatting 2018-06-23 23:35:27 +12:00
xuri 9e463b4614
- Add error return value for functions: `AddChart()`, `AddComment()`, `AddPicture()`, `AddShape()`, `AddTable()` and `SetConditionalFormat()` 
- go test has been updated
 2018-05-27 11:25:55 +08:00
Lunny Xiao 38ad20efc1
save bytes on memory instead of string 2018-05-07 16:12:51 +08:00
Ri Xu 574a6b20d1
Golang 1.9 compatible, fix issue #111 2017-09-01 12:59:15 +08:00
Ri Xu 555e2ba9a8
- Make function `TitleToNumber()` exportable, note that function `ToAlphaString()` return value calculation changes, get more info from go doc. Relate issue #63; 
- Readme and go doc updated
 2017-06-27 17:53:06 +08:00
Ri Xu dea57dd0ae Code optimize. 2017-05-24 14:17:35 +08:00
Ri Xu 70f6328150 Support set font style of shape text. Relate issue #38. 2017-05-16 20:42:01 +08:00
Ri Xu cf97118bfe - The max author and text in comment limit added; 
- go doc and go test updated
 2017-05-13 14:12:43 +08:00
Ri Xu d93a156355 Initialize comments support & go test updated. 2017-05-13 13:28:21 +08:00