p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

regmap: shift wrapping bugs in 64 bit code 

We should cast these to 64bit so that we don't truncate away the high
bits.

Fixes: afcc00b91f ('regmap: add 64-bit mode support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Dan Carpenter 2015-12-12 15:59:14 +03:00 committed by Mark Brown
parent 8b7663de6e
commit 01c377bfe2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/base/regmap/regmap.c
View File

@ -250,20 +250,20 @@ static void regmap_format_64_be(void *buf, unsigned int val, unsigned int shift)
{ {
__be64 *b = buf; __be64 *b = buf;
b[0] = cpu_to_be64(val << shift); b[0] = cpu_to_be64((u64)val << shift);
} }
static void regmap_format_64_le(void *buf, unsigned int val, unsigned int shift) static void regmap_format_64_le(void *buf, unsigned int val, unsigned int shift)
{ {
__le64 *b = buf; __le64 *b = buf;
b[0] = cpu_to_le64(val << shift); b[0] = cpu_to_le64((u64)val << shift);
} }
static void regmap_format_64_native(void *buf, unsigned int val, static void regmap_format_64_native(void *buf, unsigned int val,
unsigned int shift) unsigned int shift)
{ {
*(u64 *)buf = val << shift; *(u64 *)buf = (u64)val << shift;
} }
#endif #endif