p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fpga: dfl: fme: fix return value check in in pr_mgmt_init() 

In case of error, the function dfl_fme_create_region() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: 29de76240e ("fpga: dfl: fme: add partial reconfiguration sub feature support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Moritz Fischer <mdf@kernel.org>
Acked-by: Alan Tull <atull@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wei Yongjun 2018-08-16 14:42:13 -05:00 committed by Greg Kroah-Hartman
parent de916736aa
commit 029d727b4f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/fpga/dfl-fme-pr.c
View File

@ -420,7 +420,7 @@ static int pr_mgmt_init(struct platform_device *pdev,
/* Create region for each port */ /* Create region for each port */
fme_region = dfl_fme_create_region(pdata, mgr, fme_region = dfl_fme_create_region(pdata, mgr,
fme_br->br, i); fme_br->br, i);
if (!fme_region) { if (IS_ERR(fme_region)) {
ret = PTR_ERR(fme_region); ret = PTR_ERR(fme_region);
goto destroy_region; goto destroy_region;
} }