p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

hwmon: (dell-smm) Fail in ioctl I8K_BIOS_VERSION when bios version is not a number 

ABI of I8K_BIOS_VERSION ioctl can return only number. But new BIOS versions
contain also other characters, which does not fit into that ABI. So in case
of non digit values return -EINVAL.

Reported-by: Mario Limonciello <Mario_Limonciello@dell.com>
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Pali Rohár 2016-06-18 00:54:44 +02:00 committed by Guenter Roeck
parent 5edb56491d
commit 053ea64081
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/hwmon/dell-smm-hwmon.c
View File

@ -35,6 +35,7 @@
#include <linux/uaccess.h> #include <linux/uaccess.h>
#include <linux/io.h> #include <linux/io.h>
#include <linux/sched.h> #include <linux/sched.h>
#include <linux/ctype.h>
#include <linux/i8k.h> #include <linux/i8k.h>
@ -387,6 +388,10 @@ i8k_ioctl_unlocked(struct file *fp, unsigned int cmd, unsigned long arg)
switch (cmd) { switch (cmd) {
case I8K_BIOS_VERSION: case I8K_BIOS_VERSION:
if (!isdigit(bios_version[0]) || !isdigit(bios_version[1]) ||
!isdigit(bios_version[2]))
return -EINVAL;
val = (bios_version[0] << 16) | val = (bios_version[0] << 16) |
(bios_version[1] << 8) | bios_version[2]; (bios_version[1] << 8) | bios_version[2];
break; break;