p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

i2c: ismt: issue a warning when fail to request MSI 

Issue the warning in all error paths when unable to register MSI or its
handler.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
This commit is contained in:
Andy Shevchenko 2015-09-16 17:24:02 +03:00 committed by Wolfram Sang
parent 6befa6dd8d
commit 064181b00e
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/i2c/busses/i2c-ismt.c
View File

@ -788,11 +788,8 @@ static int ismt_int_init(struct ismt_priv *priv)
/* Try using MSI interrupts */ /* Try using MSI interrupts */
err = pci_enable_msi(priv->pci_dev); err = pci_enable_msi(priv->pci_dev);
if (err) { if (err)
dev_warn(&priv->pci_dev->dev,
"Unable to use MSI interrupts, falling back to legacy\n");
goto intx; goto intx;
}
err = devm_request_irq(&priv->pci_dev->dev, err = devm_request_irq(&priv->pci_dev->dev,
priv->pci_dev->irq, priv->pci_dev->irq,
@ -805,10 +802,13 @@ static int ismt_int_init(struct ismt_priv *priv)
goto intx; goto intx;
} }
goto done; return 0;
/* Try using legacy interrupts */ /* Try using legacy interrupts */
intx: intx:
dev_warn(&priv->pci_dev->dev,
"Unable to use MSI interrupts, falling back to legacy\n");
err = devm_request_irq(&priv->pci_dev->dev, err = devm_request_irq(&priv->pci_dev->dev,
priv->pci_dev->irq, priv->pci_dev->irq,
ismt_do_interrupt, ismt_do_interrupt,
@ -820,7 +820,6 @@ static int ismt_int_init(struct ismt_priv *priv)
return err; return err;
} }
done:
return 0; return 0;
} }