p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

proc: use do-while in name_to_int() 

Gcc doesn't know that "len" is guaranteed to be >=1 by dcache and
generates standard while-loop prologue duplicating loop condition.

	add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-27 (-27)
	function                                     old     new   delta
	name_to_int                                  104      77     -27

Link: http://lkml.kernel.org/r/20170912195213.GB17730@avx2
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Alexey Dobriyan 2017-11-17 15:26:52 -08:00 committed by Linus Torvalds
parent 3ee2a19908
commit 0746a0bc6e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/proc/util.c
View File

@ -8,7 +8,7 @@ unsigned name_to_int(const struct qstr *qstr)
if (len > 1 && *name == '0')
goto out;
while (len-- > 0) {
do {
unsigned c = *name++ - '0';
if (c > 9)
goto out;
@ -16,7 +16,7 @@ unsigned name_to_int(const struct qstr *qstr)
goto out;
n *= 10;
n += c;
}
} while (--len > 0);
return n;
out:
return ~0U;