p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[media] coda: Propagate the correct error on devm_request_threaded_irq() 

If devm_request_threaded_irq() fails, we should better propagate the real error.

Also, print out the error code in the dev_err message.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
This commit is contained in:
Fabio Estevam 2014-06-04 15:46:24 -03:00 committed by Mauro Carvalho Chehab
parent 7d37743a3e
commit 08c8d14e75
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/media/platform/coda.c
View File

@ -3773,10 +3773,11 @@ static int coda_probe(struct platform_device *pdev)
return irq; return irq;
} }
if (devm_request_threaded_irq(&pdev->dev, irq, NULL, coda_irq_handler, ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, coda_irq_handler,
IRQF_ONESHOT, dev_name(&pdev->dev), dev) < 0) { IRQF_ONESHOT, dev_name(&pdev->dev), dev);
dev_err(&pdev->dev, "failed to request irq\n"); if (ret < 0) {
return -ENOENT; dev_err(&pdev->dev, "failed to request irq: %d\n", ret);
return ret;
} }
dev->rstc = devm_reset_control_get(&pdev->dev, NULL); dev->rstc = devm_reset_control_get(&pdev->dev, NULL);