p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

staging: kpc2000: kpc_i2c: Use drvdata instead of platform_data 

The kpc_i2c driver stashes private state data in the platform_data
member of its device structure. In general, the platform_data structure
is used for passing data to the driver during probe() rather than as a
storage area for runtime state data. Instead, use the drvdata member
for all state info meant to be accessible in driver callbacks.

Signed-off-by: Geordan Neukum <gneukum1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Geordan Neukum 2019-05-26 01:18:31 +00:00 committed by Greg Kroah-Hartman
parent 73d56b8391
commit 091971897e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/kpc2000/kpc2000_i2c.c
View File

@ -589,7 +589,7 @@ static int pi2c_probe(struct platform_device *pldev)
res = platform_get_resource(pldev, IORESOURCE_MEM, 0);
priv->smba = (unsigned long)ioremap_nocache(res->start, resource_size(res));
pldev->dev.platform_data = priv;
platform_set_drvdata(pldev, priv);
priv->features |= FEATURE_IDF;
priv->features |= FEATURE_I2C_BLOCK_READ;
@ -620,7 +620,7 @@ static int pi2c_remove(struct platform_device *pldev)
{
struct i2c_device *lddev;
lddev = (struct i2c_device *)pldev->dev.platform_data;
lddev = (struct i2c_device *)platform_get_drvdata(pldev);
i2c_del_adapter(&lddev->adapter);