p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

dm log writes: don't use all the cpu while waiting to log blocks 

The check to see if the logging kthread needs to go to sleep is wrong,
it checks lc->pending_blocks, which will be non-0 if there are any
blocks that are pending, whether they are ready to be logged or not.
What we really want is to go to sleep until it's time to log blocks, so
change this check so we do actually go to sleep in between flushes.

Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
This commit is contained in:
Josef Bacik 2017-07-28 10:42:24 -04:00 committed by Mike Snitzer
parent cf0dec6674
commit 0c79c62021
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/md/dm-log-writes.c
View File

@ -399,7 +399,7 @@ static int log_writes_kthread(void *arg)
if (!try_to_freeze()) {
set_current_state(TASK_INTERRUPTIBLE);
if (!kthread_should_stop() &&
!atomic_read(&lc->pending_blocks))
list_empty(&lc->logging_blocks))
schedule();
__set_current_state(TASK_RUNNING);
}