p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net: phy: marvell: Replace mdelay() with msleep() in m88e1116r_config_init() 

m88e1116r_config_init() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jia-Ju Bai 2018-07-27 16:34:25 +08:00 committed by David S. Miller
parent 6ae5cbc418
commit 0df125d05d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/phy/marvell.c
View File

@ -679,7 +679,7 @@ static int m88e1116r_config_init(struct phy_device *phydev)
if (err < 0) if (err < 0)
return err; return err;
mdelay(500); msleep(500);
err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE); err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE);
if (err < 0) if (err < 0)