p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

mmc: tmio: make tmio_mmc_request function more readable 

This part confused me and I had to read it twice until I got it. Let's
follow the standard pattern to bail out if something is wrong and keep
in the body of the function when everything is as expected.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
Wolfram Sang 2017-05-19 15:31:50 +02:00 committed by Ulf Hansson
parent e1df7ae30b
commit 10c998ef97
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/mmc/host/tmio_mmc_core.c
View File

@ -926,11 +926,12 @@ static void tmio_mmc_request(struct mmc_host *mmc, struct mmc_request *mrq)
} }
ret = tmio_mmc_start_command(host, mrq->cmd); ret = tmio_mmc_start_command(host, mrq->cmd);
if (!ret) { if (ret)
schedule_delayed_work(&host->delayed_reset_work, goto fail;
msecs_to_jiffies(CMDREQ_TIMEOUT));
return; schedule_delayed_work(&host->delayed_reset_work,
} msecs_to_jiffies(CMDREQ_TIMEOUT));
return;
fail: fail:
host->force_pio = false; host->force_pio = false;