p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

dmaengine: bcm-sba-raid: Remove redundant next_count from sba_request 

The next_count in sba_request is redundant because same information
is captured by next_pending_count. This patch removes next_count
from sba_request.

Signed-off-by: Anup Patel <anup.patel@broadcom.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
This commit is contained in:
Anup Patel 2017-08-22 15:26:53 +05:30 committed by Vinod Koul
parent 57a2850859
commit 10f1a33080
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/dma/bcm-sba-raid.c
View File

@ -111,7 +111,6 @@ struct sba_request {
/* Chained requests management */ /* Chained requests management */
struct sba_request *first; struct sba_request *first;
struct list_head next; struct list_head next;
unsigned int next_count;
atomic_t next_pending_count; atomic_t next_pending_count;
/* BRCM message data */ /* BRCM message data */
void *resp; void *resp;
@ -221,7 +220,6 @@ static struct sba_request *sba_alloc_request(struct sba_device *sba)
req->flags = SBA_REQUEST_STATE_ALLOCED; req->flags = SBA_REQUEST_STATE_ALLOCED;
req->first = req; req->first = req;
INIT_LIST_HEAD(&req->next); INIT_LIST_HEAD(&req->next);
req->next_count = 1;
atomic_set(&req->next_pending_count, 1); atomic_set(&req->next_pending_count, 1);
dma_async_tx_descriptor_init(&req->tx, &sba->dma_chan); dma_async_tx_descriptor_init(&req->tx, &sba->dma_chan);
@ -342,8 +340,7 @@ static void sba_chain_request(struct sba_request *first,
list_add_tail(&req->next, &first->next); list_add_tail(&req->next, &first->next);
req->first = first; req->first = first;
first->next_count++; atomic_inc(&first->next_pending_count);
atomic_set(&first->next_pending_count, first->next_count);
spin_unlock_irqrestore(&sba->reqs_lock, flags); spin_unlock_irqrestore(&sba->reqs_lock, flags);
} }
@ -1501,7 +1498,6 @@ static int sba_prealloc_channel_resources(struct sba_device *sba)
req->sba = sba; req->sba = sba;
req->flags = SBA_REQUEST_STATE_FREE; req->flags = SBA_REQUEST_STATE_FREE;
INIT_LIST_HEAD(&req->next); INIT_LIST_HEAD(&req->next);
req->next_count = 1;
atomic_set(&req->next_pending_count, 0); atomic_set(&req->next_pending_count, 0);
req->resp = sba->resp_base + p; req->resp = sba->resp_base + p;
req->resp_dma = sba->resp_dma_base + p; req->resp_dma = sba->resp_dma_base + p;