p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

dmaengine: mic_x100_dma: use devm_kzalloc to fix an issue 

The following patch introduced an issue.
    commit f6206f00d8 ("dmaengine: mic_x100_dma: use the new helper to simplify the code")

This issue is :

	kfree(mic_dma_dev)
	.....
	dma_async_device_unregister(mic_dma_dev->device);

Free the memory, and use it again.

So use devm_kzalloc to allocate mic_dma_dev to fix it.

When the Devres try to release the resources, it will call release at the
following order:

	dma_async_device_unregister(mic_dma_dev->device);
	.....
	kfree(mic_dma_dev)

Fixes: f6206f00d8 ("dmaengine: mic_x100_dma: use the new helper to simplify the code")
Signed-off-by: Huang Shijie <sjhuang@iluvatar.ai>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Huang Shijie 2018-08-22 10:40:27 +08:00 committed by Vinod Koul
parent 5b394b2ddf
commit 111b009f7e
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/dma/mic_x100_dma.c
View File

@ -639,7 +639,7 @@ static struct mic_dma_device *mic_dma_dev_reg(struct mbus_device *mbdev,
int ret; int ret;
struct device *dev = &mbdev->dev; struct device *dev = &mbdev->dev;
mic_dma_dev = kzalloc(sizeof(*mic_dma_dev), GFP_KERNEL); mic_dma_dev = devm_kzalloc(dev, sizeof(*mic_dma_dev), GFP_KERNEL);
if (!mic_dma_dev) { if (!mic_dma_dev) {
ret = -ENOMEM; ret = -ENOMEM;
goto alloc_error; goto alloc_error;
@ -664,7 +664,6 @@ static struct mic_dma_device *mic_dma_dev_reg(struct mbus_device *mbdev,
reg_error: reg_error:
mic_dma_uninit(mic_dma_dev); mic_dma_uninit(mic_dma_dev);
init_error: init_error:
kfree(mic_dma_dev);
mic_dma_dev = NULL; mic_dma_dev = NULL;
alloc_error: alloc_error:
dev_err(dev, "Error at %s %d ret=%d\n", __func__, __LINE__, ret); dev_err(dev, "Error at %s %d ret=%d\n", __func__, __LINE__, ret);
@ -674,7 +673,6 @@ static struct mic_dma_device *mic_dma_dev_reg(struct mbus_device *mbdev,
static void mic_dma_dev_unreg(struct mic_dma_device *mic_dma_dev) static void mic_dma_dev_unreg(struct mic_dma_device *mic_dma_dev)
{ {
mic_dma_uninit(mic_dma_dev); mic_dma_uninit(mic_dma_dev);
kfree(mic_dma_dev);
} }
/* DEBUGFS CODE */ /* DEBUGFS CODE */