p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

storvsc: Set the error code correctly in failure conditions 

In the function storvsc_channel_init(), error code was not getting
set correctly in some of the failure cases. Fix this issue.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
This commit is contained in:
K. Y. Srinivasan 2015-08-13 08:43:52 -07:00 committed by James Bottomley
parent b95f5be090
commit 111f2d15b5
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/scsi/storvsc_drv.c
View File

@ -952,8 +952,10 @@ static int storvsc_channel_init(struct hv_device *device)
}
if (vstor_packet->operation != VSTOR_OPERATION_COMPLETE_IO ||
vstor_packet->status != 0)
vstor_packet->status != 0) {
ret = -EINVAL;
goto cleanup;
}
for (i = 0; i < ARRAY_SIZE(vmstor_protocols); i++) {
@ -1032,8 +1034,10 @@ static int storvsc_channel_init(struct hv_device *device)
}
if (vstor_packet->operation != VSTOR_OPERATION_COMPLETE_IO ||
vstor_packet->status != 0)
vstor_packet->status != 0) {
ret = -EINVAL;
goto cleanup;
}
/*
* Check to see if multi-channel support is there.
@ -1070,8 +1074,10 @@ static int storvsc_channel_init(struct hv_device *device)
}
if (vstor_packet->operation != VSTOR_OPERATION_COMPLETE_IO ||
vstor_packet->status != 0)
vstor_packet->status != 0) {
ret = -EINVAL;
goto cleanup;
}
if (process_sub_channels)
handle_multichannel_storage(device, max_chns);