p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[media] DaVinci-VPFE-Capture: Delete three error messages for a failed memory allocation 

The script "checkpatch.pl" pointed information out like the following.

WARNING: Possible unnecessary 'out of memory' message

Thus remove such a logging statement in two functions.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Markus Elfring 2016-10-12 05:22:47 -03:00 committed by Mauro Carvalho Chehab
parent ed011a23c9
commit 11691f0e8a
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/media/platform/davinci/vpfe_capture.c
View File

@ -512,11 +512,9 @@ static int vpfe_open(struct file *file)
/* Allocate memory for the file handle object */ /* Allocate memory for the file handle object */
fh = kmalloc(sizeof(struct vpfe_fh), GFP_KERNEL); fh = kmalloc(sizeof(struct vpfe_fh), GFP_KERNEL);
if (NULL == fh) { if (!fh)
v4l2_err(&vpfe_dev->v4l2_dev,
"unable to allocate memory for file handle object\n");
return -ENOMEM; return -ENOMEM;
}
/* store pointer to fh in private_data member of file */ /* store pointer to fh in private_data member of file */
file->private_data = fh; file->private_data = fh;
fh->vpfe_dev = vpfe_dev; fh->vpfe_dev = vpfe_dev;
@ -1851,11 +1849,8 @@ static int vpfe_probe(struct platform_device *pdev)
/* Allocate memory for ccdc configuration */ /* Allocate memory for ccdc configuration */
ccdc_cfg = kmalloc(sizeof(struct ccdc_config), GFP_KERNEL); ccdc_cfg = kmalloc(sizeof(struct ccdc_config), GFP_KERNEL);
if (NULL == ccdc_cfg) { if (!ccdc_cfg)
v4l2_err(pdev->dev.driver,
"Memory allocation failed for ccdc_cfg\n");
goto probe_free_dev_mem; goto probe_free_dev_mem;
}
mutex_lock(&ccdc_lock); mutex_lock(&ccdc_lock);
@ -1942,8 +1937,6 @@ static int vpfe_probe(struct platform_device *pdev)
sizeof(*vpfe_dev->sd), sizeof(*vpfe_dev->sd),
GFP_KERNEL); GFP_KERNEL);
if (NULL == vpfe_dev->sd) { if (NULL == vpfe_dev->sd) {
v4l2_err(&vpfe_dev->v4l2_dev,
"unable to allocate memory for subdevice pointers\n");
ret = -ENOMEM; ret = -ENOMEM;
goto probe_out_video_unregister; goto probe_out_video_unregister;
} }