p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

power: supply: axp288_fuel_gauge: Remove unnecessary irq?_en register writes 

Setting the irq_enable bits is taken care of by the irq chip when we
request the irqs and the driver should not be meddling with the
irq?_en registers itself.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
This commit is contained in:
Hans de Goede 2016-12-22 13:00:11 +01:00 committed by Sebastian Reichel
parent de4fb05142
commit 1169735dc2
1 changed files with 0 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
drivers/power/supply/axp288_fuel_gauge.c
View File

@ -50,18 +50,6 @@
#define CHRG_CCCV_CV_4350MV 0x3 /* 4.35V */ #define CHRG_CCCV_CV_4350MV 0x3 /* 4.35V */
#define CHRG_CCCV_CHG_EN (1 << 7) #define CHRG_CCCV_CHG_EN (1 << 7)
#define TEMP_IRQ_CFG_QWBTU (1 << 0)
#define TEMP_IRQ_CFG_WBTU (1 << 1)
#define TEMP_IRQ_CFG_QWBTO (1 << 2)
#define TEMP_IRQ_CFG_WBTO (1 << 3)
#define TEMP_IRQ_CFG_MASK 0xf
#define FG_IRQ_CFG_LOWBATT_WL2 (1 << 0)
#define FG_IRQ_CFG_LOWBATT_WL1 (1 << 1)
#define FG_IRQ_CFG_LOWBATT_MASK 0x3
#define LOWBAT_IRQ_STAT_LOWBATT_WL2 (1 << 0)
#define LOWBAT_IRQ_STAT_LOWBATT_WL1 (1 << 1)
#define FG_CNTL_OCV_ADJ_STAT (1 << 2) #define FG_CNTL_OCV_ADJ_STAT (1 << 2)
#define FG_CNTL_OCV_ADJ_EN (1 << 3) #define FG_CNTL_OCV_ADJ_EN (1 << 3)
#define FG_CNTL_CAP_ADJ_STAT (1 << 4) #define FG_CNTL_CAP_ADJ_STAT (1 << 4)
@ -710,20 +698,6 @@ static void fuel_gauge_init_irq(struct axp288_fg_info *info)
} }
} }
static void fuel_gauge_init_hw_regs(struct axp288_fg_info *info)
{
unsigned int val;
/* enable interrupts */
val = fuel_gauge_reg_readb(info, AXP20X_IRQ3_EN);
val |= TEMP_IRQ_CFG_MASK;
fuel_gauge_reg_writeb(info, AXP20X_IRQ3_EN, val);
val = fuel_gauge_reg_readb(info, AXP20X_IRQ4_EN);
val |= FG_IRQ_CFG_LOWBATT_MASK;
val = fuel_gauge_reg_writeb(info, AXP20X_IRQ4_EN, val);
}
static int axp288_fuel_gauge_probe(struct platform_device *pdev) static int axp288_fuel_gauge_probe(struct platform_device *pdev)
{ {
int ret = 0; int ret = 0;
@ -782,7 +756,6 @@ static int axp288_fuel_gauge_probe(struct platform_device *pdev)
fuel_gauge_create_debugfs(info); fuel_gauge_create_debugfs(info);
fuel_gauge_init_irq(info); fuel_gauge_init_irq(info);
fuel_gauge_init_hw_regs(info);
schedule_delayed_work(&info->status_monitor, STATUS_MON_DELAY_JIFFIES); schedule_delayed_work(&info->status_monitor, STATUS_MON_DELAY_JIFFIES);
return 0; return 0;