fix a page leak in vhost_scsi_iov_to_sgl() error recovery
we are advancing sg as we go, so the pages we need to drop in case of error are *before* the current sg. Cc: stable@vger.kernel.org Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
parent
09cf698a59
commit
11d49e9d08
|
@ -688,6 +688,7 @@ vhost_scsi_iov_to_sgl(struct vhost_scsi_cmd *cmd, bool write,
|
|||
struct scatterlist *sg, int sg_count)
|
||||
{
|
||||
size_t off = iter->iov_offset;
|
||||
struct scatterlist *p = sg;
|
||||
int i, ret;
|
||||
|
||||
for (i = 0; i < iter->nr_segs; i++) {
|
||||
|
@ -696,8 +697,8 @@ vhost_scsi_iov_to_sgl(struct vhost_scsi_cmd *cmd, bool write,
|
|||
|
||||
ret = vhost_scsi_map_to_sgl(cmd, base, len, sg, write);
|
||||
if (ret < 0) {
|
||||
for (i = 0; i < sg_count; i++) {
|
||||
struct page *page = sg_page(&sg[i]);
|
||||
while (p < sg) {
|
||||
struct page *page = sg_page(p++);
|
||||
if (page)
|
||||
put_page(page);
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue