p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ipmi_ssif: Fix uninitialized variable issue 

Currently, function ssif_remove returns _rv_, which is a variable that
is never initialized.

Fix this by removing variable _rv_ and return 0 instead.

Addresses-Coverity-ID: 1467999 ("Uninitialized scalar variable")
Fixes: 6a0d23ed33 ("ipmi: ipmi_unregister_smi() cannot fail, have it
return void")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
This commit is contained in:
Gustavo A. R. Silva 2018-04-19 08:24:29 -05:00 committed by Corey Minyard
parent 6b2e54f7ba
commit 1211229399
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/char/ipmi/ipmi_ssif.c
View File

@ -1227,7 +1227,6 @@ static int ssif_remove(struct i2c_client *client)
struct ssif_info *ssif_info = i2c_get_clientdata(client);
struct ipmi_smi *intf;
struct ssif_addr_info *addr_info;
int rv;
if (!ssif_info)
return 0;
@ -1247,7 +1246,7 @@ static int ssif_remove(struct i2c_client *client)
}
}
return rv;
return 0;
}
static int do_cmd(struct i2c_client *client, int len, unsigned char *msg,