p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

NFS: Reduce lock contention in nfs_try_to_update_request() 

Micro-optimisation to move the lockless check into the for(;;) loop.

Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
This commit is contained in:
Trond Myklebust 2017-07-17 09:37:12 -04:00
parent 82749dd4ef
commit 1403390d83
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fs/nfs/write.c
View File

@ -1097,13 +1097,12 @@ static struct nfs_page *nfs_try_to_update_request(struct inode *inode,
unsigned int end; unsigned int end;
int error; int error;
if (!PagePrivate(page))
return NULL;
end = offset + bytes; end = offset + bytes;
spin_lock(&inode->i_lock);
for (;;) { for (;;) {
if (!(PagePrivate(page) || PageSwapCache(page)))
return NULL;
spin_lock(&inode->i_lock);
req = nfs_page_find_head_request_locked(NFS_I(inode), page); req = nfs_page_find_head_request_locked(NFS_I(inode), page);
if (req == NULL) if (req == NULL)
goto out_unlock; goto out_unlock;
@ -1132,7 +1131,6 @@ static struct nfs_page *nfs_try_to_update_request(struct inode *inode,
nfs_release_request(req); nfs_release_request(req);
if (error != 0) if (error != 0)
goto out_err; goto out_err;
spin_lock(&inode->i_lock);
} }
/* Okay, the request matches. Update the region */ /* Okay, the request matches. Update the region */