p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

iio: adc: mxs-lradc: Fix return value check in mxs_lradc_adc_probe() 

In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test. Also add NULL test for iores.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
This commit is contained in:
Wei Yongjun 2017-05-16 15:26:12 +00:00 committed by Jonathan Cameron
parent 948588e25b
commit 1454e15bc2
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/iio/adc/mxs-lradc-adc.c
View File

@ -718,9 +718,12 @@ static int mxs_lradc_adc_probe(struct platform_device *pdev)
adc->dev = dev; adc->dev = dev;
iores = platform_get_resource(pdev, IORESOURCE_MEM, 0); iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!iores)
return -EINVAL;
adc->base = devm_ioremap(dev, iores->start, resource_size(iores)); adc->base = devm_ioremap(dev, iores->start, resource_size(iores));
if (IS_ERR(adc->base)) if (!adc->base)
return PTR_ERR(adc->base); return -ENOMEM;
init_completion(&adc->completion); init_completion(&adc->completion);
spin_lock_init(&adc->lock); spin_lock_init(&adc->lock);