p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

IDE: Deletion of an unnecessary check before the function call "module_put" 

The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Markus Elfring 2014-11-21 20:22:32 +01:00 committed by David S. Miller
parent 6ce4436c9c
commit 1746fbe565
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/ide/ide.c
View File

@ -101,8 +101,7 @@ void ide_device_put(ide_drive_t *drive)
struct device *host_dev = drive->hwif->host->dev[0]; struct device *host_dev = drive->hwif->host->dev[0];
struct module *module = host_dev ? host_dev->driver->owner : NULL; struct module *module = host_dev ? host_dev->driver->owner : NULL;
if (module) module_put(module);
module_put(module);
#endif #endif
put_device(&drive->gendev); put_device(&drive->gendev);
} }