p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

i2c: i2c-cros-ec-tunnel: Reduce logging noise 

If an i2c access through i2c-cros-ec-tunnel returns an error, the following
log message is seen on the console.

cros-ec-i2c-tunnel ff200000.spi:ec@0:i2c-tunnel:
			Error parsing EC i2c message -121

This can happen a lot if, for example, the i2c-detect command is executed.

Since it is perfectly normal for an i2c controller to report an error,
drop the message. Also, report -ENXIO instead of -EREMOTEIO if the access
error is due to NAK from the device, and return -EIO instead of -EREMOTEIO
for other errors, as suggested in Documentation/i2c/fault-codes.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
This commit is contained in:
Guenter Roeck 2016-07-26 15:34:01 -07:00 committed by Wolfram Sang
parent cefae80249
commit 22ae11245e
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/i2c/busses/i2c-cros-ec-tunnel.c
View File

@ -154,8 +154,10 @@ static int ec_i2c_parse_response(const u8 *buf, struct i2c_msg i2c_msgs[],
resp = (const struct ec_response_i2c_passthru *)buf; resp = (const struct ec_response_i2c_passthru *)buf;
if (resp->i2c_status & EC_I2C_STATUS_TIMEOUT) if (resp->i2c_status & EC_I2C_STATUS_TIMEOUT)
return -ETIMEDOUT; return -ETIMEDOUT;
else if (resp->i2c_status & EC_I2C_STATUS_NAK)
return -ENXIO;
else if (resp->i2c_status & EC_I2C_STATUS_ERROR) else if (resp->i2c_status & EC_I2C_STATUS_ERROR)
return -EREMOTEIO; return -EIO;
/* Other side could send us back fewer messages, but not more */ /* Other side could send us back fewer messages, but not more */
if (resp->num_msgs > *num) if (resp->num_msgs > *num)
@ -222,10 +224,8 @@ static int ec_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg i2c_msgs[],
} }
result = ec_i2c_parse_response(msg->data, i2c_msgs, &num); result = ec_i2c_parse_response(msg->data, i2c_msgs, &num);
if (result < 0) { if (result < 0)
dev_err(dev, "Error parsing EC i2c message %d\n", result);
goto exit; goto exit;
}
/* Indicate success by saying how many messages were sent */ /* Indicate success by saying how many messages were sent */
result = num; result = num;