p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

mtd: nand: mtk: fix error return code in mtk_ecc_probe() 

platform_get_irq() returns an error code, but the mtk_ecc driver
ignores it and always returns -EINVAL. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.

Print and propagate the return value of platform_get_irq on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
This commit is contained in:
Gustavo A. R. Silva 2017-08-09 11:35:21 -05:00 committed by Boris Brezillon
parent 2192a8ddc1
commit 238709b220
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/mtd/nand/mtk_ecc.c
View File

@ -464,8 +464,8 @@ static int mtk_ecc_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0); irq = platform_get_irq(pdev, 0);
if (irq < 0) { if (irq < 0) {
dev_err(dev, "failed to get irq\n"); dev_err(dev, "failed to get irq: %d\n", irq);
return -EINVAL; return irq;
} }
ret = dma_set_mask(dev, DMA_BIT_MASK(32)); ret = dma_set_mask(dev, DMA_BIT_MASK(32));