p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

staging: rtl8192e: make return of 0 explicit 

Delete unnecessary use of a local variable to immediately return 0.

A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
local idexpression ret;
expression e;
position p;
@@

-ret = 0;
... when != ret = e
return
- ret
+ 0
  ;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Julia Lawall 2014-05-19 06:31:12 +02:00 committed by Greg Kroah-Hartman
parent 9cdf838b3a
commit 26e2fa765c
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/rtl8192e/rtl8192e/rtl_core.c
View File

@ -1915,8 +1915,7 @@ int rtl8192_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev)); memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
if (queue_index == TXCMD_QUEUE) { if (queue_index == TXCMD_QUEUE) {
rtl8192_tx_cmd(dev, skb); rtl8192_tx_cmd(dev, skb);
ret = 0; return 0;
return ret;
} else { } else {
tcb_desc->RATRIndex = 7; tcb_desc->RATRIndex = 7;
tcb_desc->bTxDisableRateFallBack = 1; tcb_desc->bTxDisableRateFallBack = 1;