p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

rtlwifi: no need to check return value of debugfs_create functions 

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
Greg Kroah-Hartman 2019-01-22 16:21:33 +01:00 committed by Kalle Valo
parent c922a3a02d
commit 3059785bb7
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/net/wireless/realtek/rtlwifi/debug.c
View File

@ -463,12 +463,9 @@ static const struct file_operations file_ops_common_write = {
#define RTL_DEBUGFS_ADD_CORE(name, mode, fopname) \
do { \
rtl_debug_priv_ ##name.rtlpriv = rtlpriv; \
if (!debugfs_create_file(#name, mode, \
parent, &rtl_debug_priv_ ##name, \
&file_ops_ ##fopname)) \
pr_err("Unable to initialize debugfs:%s/%s\n", \
rtlpriv->dbg.debugfs_name, \
#name); \
debugfs_create_file(#name, mode, parent, \
&rtl_debug_priv_ ##name, \
&file_ops_ ##fopname); \
} while (0)
#define RTL_DEBUGFS_ADD(name) \
@ -486,11 +483,6 @@ void rtl_debug_add_one(struct ieee80211_hw *hw)
rtlpriv->dbg.debugfs_dir =
debugfs_create_dir(rtlpriv->dbg.debugfs_name, debugfs_topdir);
if (!rtlpriv->dbg.debugfs_dir) {
pr_err("Unable to init debugfs:/%s/%s\n", rtlpriv->cfg->name,
rtlpriv->dbg.debugfs_name);
return;
}
parent = rtlpriv->dbg.debugfs_dir;