p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

signal: Replace memset(info,...) with clear_siginfo for clarity 

The function clear_siginfo is just a nice wrapper around memset so
this results in no functional change.  This change makes mistakes
a little more difficult and it makes it clearer what is going on.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
This commit is contained in:
Eric W. Biederman 2017-08-18 19:56:27 -05:00
parent 5f74972ce6
commit 3b10db2b06
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/um/kernel/trap.c
View File

@ -306,7 +306,7 @@ void relay_signal(int sig, struct siginfo *si, struct uml_pt_regs *regs)
arch_examine_signal(sig, regs); arch_examine_signal(sig, regs);
memset(&clean_si, 0, sizeof(clean_si)); clear_siginfo(&clean_si);
clean_si.si_signo = si->si_signo; clean_si.si_signo = si->si_signo;
clean_si.si_errno = si->si_errno; clean_si.si_errno = si->si_errno;
clean_si.si_code = si->si_code; clean_si.si_code = si->si_code;

4
drivers/usb/core/devio.c
View File

@ -595,7 +595,7 @@ static void async_completed(struct urb *urb)
as->status = urb->status; as->status = urb->status;
signr = as->signr; signr = as->signr;
if (signr) { if (signr) {
memset(&sinfo, 0, sizeof(sinfo)); clear_siginfo(&sinfo);
sinfo.si_signo = as->signr; sinfo.si_signo = as->signr;
sinfo.si_errno = as->status; sinfo.si_errno = as->status;
sinfo.si_code = SI_ASYNCIO; sinfo.si_code = SI_ASYNCIO;
@ -2613,7 +2613,7 @@ static void usbdev_remove(struct usb_device *udev)
wake_up_all(&ps->wait); wake_up_all(&ps->wait);
list_del_init(&ps->list); list_del_init(&ps->list);
if (ps->discsignr) { if (ps->discsignr) {
memset(&sinfo, 0, sizeof(sinfo)); clear_siginfo(&sinfo);
sinfo.si_signo = ps->discsignr; sinfo.si_signo = ps->discsignr;
sinfo.si_errno = EPIPE; sinfo.si_errno = EPIPE;
sinfo.si_code = SI_ASYNCIO; sinfo.si_code = SI_ASYNCIO;

2
kernel/seccomp.c
View File

@ -515,7 +515,7 @@ void put_seccomp_filter(struct task_struct *tsk)
static void seccomp_init_siginfo(siginfo_t *info, int syscall, int reason) static void seccomp_init_siginfo(siginfo_t *info, int syscall, int reason)
{ {
memset(info, 0, sizeof(*info)); clear_siginfo(info);
info->si_signo = SIGSYS; info->si_signo = SIGSYS;
info->si_code = SYS_SECCOMP; info->si_code = SYS_SECCOMP;
info->si_call_addr = (void __user *)KSTK_EIP(current); info->si_call_addr = (void __user *)KSTK_EIP(current);

2
kernel/time/posix-timers.c
View File

@ -462,7 +462,7 @@ static struct k_itimer * alloc_posix_timer(void)
kmem_cache_free(posix_timers_cache, tmr); kmem_cache_free(posix_timers_cache, tmr);
return NULL; return NULL;
} }
memset(&tmr->sigq->info, 0, sizeof(siginfo_t)); clear_siginfo(&tmr->sigq->info);
return tmr; return tmr;
} }