p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net: phy: fix sign type error in genphy_config_eee_advert 

In genphy_config_eee_advert, the return value of phy_read_mmd_indirect is
checked to know if the register could be accessed but the result is
assigned to a 'u32'.
Changing to 'int' to correctly get errors from phy_read_mmd_indirect.

Fixes: d853d145ea ("net: phy: add an option to disable EEE advertisement")
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
jbrunet 2016-12-19 16:05:36 +01:00 committed by David S. Miller
parent 0a28cfd51e
commit 3bb9ab6327
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/phy/phy_device.c
View File

@ -1187,8 +1187,8 @@ static int genphy_config_advert(struct phy_device *phydev)
*/ */
static int genphy_config_eee_advert(struct phy_device *phydev) static int genphy_config_eee_advert(struct phy_device *phydev)
{ {
u32 broken = phydev->eee_broken_modes; int broken = phydev->eee_broken_modes;
u32 old_adv, adv; int old_adv, adv;
/* Nothing to disable */ /* Nothing to disable */
if (!broken) if (!broken)