p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

iwlwifi: mvm: use proper sta_addr in firmware API 

There's no point to declare an address as a __le32/__le16
and then only take a pointer to it anyway, change that to
just a sta_addr[ETH_ALEN].

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
This commit is contained in:
Johannes Berg 2017-03-09 14:08:51 +01:00 committed by Luca Coelho
parent 72361c3d28
commit 3dc6dd9698
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/wireless/intel/iwlwifi/mvm/fw-api-tx.h
View File

@ -594,8 +594,7 @@ struct iwl_mvm_tx_resp {
/** /**
* struct iwl_mvm_ba_notif - notifies about reception of BA * struct iwl_mvm_ba_notif - notifies about reception of BA
* ( BA_NOTIF = 0xc5 ) * ( BA_NOTIF = 0xc5 )
* @sta_addr_lo32: lower 32 bits of the MAC address * @sta_addr: MAC address
* @sta_addr_hi16: upper 16 bits of the MAC address
* @sta_id: Index of recipient (BA-sending) station in fw's station table * @sta_id: Index of recipient (BA-sending) station in fw's station table
* @tid: tid of the session * @tid: tid of the session
* @seq_ctl: * @seq_ctl:
@ -609,8 +608,7 @@ struct iwl_mvm_tx_resp {
* for Tx-ing then this value will be set to 0 by FW. * for Tx-ing then this value will be set to 0 by FW.
*/ */
struct iwl_mvm_ba_notif { struct iwl_mvm_ba_notif {
__le32 sta_addr_lo32; u8 sta_addr[ETH_ALEN];
__le16 sta_addr_hi16;
__le16 reserved; __le16 reserved;
u8 sta_id; u8 sta_id;

2
drivers/net/wireless/intel/iwlwifi/mvm/tx.c
View File

@ -1850,7 +1850,7 @@ void iwl_mvm_rx_ba_notif(struct iwl_mvm *mvm, struct iwl_rx_cmd_buffer *rxb)
IWL_DEBUG_TX_REPLY(mvm, IWL_DEBUG_TX_REPLY(mvm,
"BA_NOTIFICATION Received from %pM, sta_id = %d\n", "BA_NOTIFICATION Received from %pM, sta_id = %d\n",
(u8 *)&ba_notif->sta_addr_lo32, ba_notif->sta_id); ba_notif->sta_addr, ba_notif->sta_id);
IWL_DEBUG_TX_REPLY(mvm, IWL_DEBUG_TX_REPLY(mvm,
"TID = %d, SeqCtl = %d, bitmap = 0x%llx, scd_flow = %d, scd_ssn = %d sent:%d, acked:%d\n", "TID = %d, SeqCtl = %d, bitmap = 0x%llx, scd_flow = %d, scd_ssn = %d sent:%d, acked:%d\n",