p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[media] nuvoton-cir: use request_muxed_region for accessing EFM registers 

The two EFM ioports are accessed by drivers for other parts of the Nuvoton
Super-IO chips too. Therefore access to these ioports needs to be
protected by using request_muxed_region (like it's implemented e.g. in
hwmon/nct6775 already).

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Heiner Kallweit 2015-12-30 14:39:22 -02:00 committed by Mauro Carvalho Chehab
parent a73cfe527c
commit 3def9ad6d3
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/media/rc/nuvoton-cir.c
View File

@ -80,17 +80,24 @@ static inline void nvt_clear_reg_bit(struct nvt_dev *nvt, u8 val, u8 reg)
} }
/* enter extended function mode */ /* enter extended function mode */
static inline void nvt_efm_enable(struct nvt_dev *nvt) static inline int nvt_efm_enable(struct nvt_dev *nvt)
{ {
if (!request_muxed_region(nvt->cr_efir, 2, NVT_DRIVER_NAME))
return -EBUSY;
/* Enabling Extended Function Mode explicitly requires writing 2x */ /* Enabling Extended Function Mode explicitly requires writing 2x */
outb(EFER_EFM_ENABLE, nvt->cr_efir); outb(EFER_EFM_ENABLE, nvt->cr_efir);
outb(EFER_EFM_ENABLE, nvt->cr_efir); outb(EFER_EFM_ENABLE, nvt->cr_efir);
return 0;
} }
/* exit extended function mode */ /* exit extended function mode */
static inline void nvt_efm_disable(struct nvt_dev *nvt) static inline void nvt_efm_disable(struct nvt_dev *nvt)
{ {
outb(EFER_EFM_DISABLE, nvt->cr_efir); outb(EFER_EFM_DISABLE, nvt->cr_efir);
release_region(nvt->cr_efir, 2);
} }
/* /*