p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

configfs: Fix bool initialization/comparison 

Bool initializations should use true and false. Bool tests don't need
comparisons.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Thomas Meyer 2017-10-07 16:02:21 +02:00 committed by Christoph Hellwig
parent 33d930e59a
commit 3f6928c347
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
fs/configfs/file.c
View File

@ -166,7 +166,7 @@ configfs_read_bin_file(struct file *file, char __user *buf,
retval = -ETXTBSY; retval = -ETXTBSY;
goto out; goto out;
} }
buffer->read_in_progress = 1; buffer->read_in_progress = true;
if (buffer->needs_read_fill) { if (buffer->needs_read_fill) {
/* perform first read with buf == NULL to get extent */ /* perform first read with buf == NULL to get extent */
@ -325,7 +325,7 @@ configfs_write_bin_file(struct file *file, const char __user *buf,
len = -ETXTBSY; len = -ETXTBSY;
goto out; goto out;
} }
buffer->write_in_progress = 1; buffer->write_in_progress = true;
/* buffer grows? */ /* buffer grows? */
if (*ppos + count > buffer->bin_buffer_size) { if (*ppos + count > buffer->bin_buffer_size) {
@ -429,8 +429,8 @@ static int check_perm(struct inode * inode, struct file * file, int type)
} }
mutex_init(&buffer->mutex); mutex_init(&buffer->mutex);
buffer->needs_read_fill = 1; buffer->needs_read_fill = 1;
buffer->read_in_progress = 0; buffer->read_in_progress = false;
buffer->write_in_progress = 0; buffer->write_in_progress = false;
buffer->ops = ops; buffer->ops = ops;
file->private_data = buffer; file->private_data = buffer;
goto Done; goto Done;
@ -488,10 +488,10 @@ static int configfs_release_bin_file(struct inode *inode, struct file *filp)
ssize_t len = 0; ssize_t len = 0;
int ret; int ret;
buffer->read_in_progress = 0; buffer->read_in_progress = false;
if (buffer->write_in_progress) { if (buffer->write_in_progress) {
buffer->write_in_progress = 0; buffer->write_in_progress = false;
len = bin_attr->write(item, buffer->bin_buffer, len = bin_attr->write(item, buffer->bin_buffer,
buffer->bin_buffer_size); buffer->bin_buffer_size);