p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

gpio: of: optimize "gpios" property parsing of of_parse_own_gpio() 

Call of_property_read_u32_array() only once rather than iterating
of_property_read_u32_index().

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Masahiro Yamada 2016-06-14 19:07:03 +09:00 committed by Linus Walleij
parent 7e7c059cb5
commit 3f9547e1c9
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/gpio/gpiolib-of.c
View File

@ -140,7 +140,7 @@ static struct gpio_desc *of_parse_own_gpio(struct device_node *np,
.flags = &xlate_flags, .flags = &xlate_flags,
}; };
u32 tmp; u32 tmp;
int i, ret; int ret;
chip_np = np->parent; chip_np = np->parent;
if (!chip_np) if (!chip_np)
@ -159,12 +159,10 @@ static struct gpio_desc *of_parse_own_gpio(struct device_node *np,
gg_data.gpiospec.args_count = tmp; gg_data.gpiospec.args_count = tmp;
gg_data.gpiospec.np = chip_np; gg_data.gpiospec.np = chip_np;
for (i = 0; i < tmp; i++) { ret = of_property_read_u32_array(np, "gpios", gg_data.gpiospec.args,
ret = of_property_read_u32_index(np, "gpios", i, tmp);
&gg_data.gpiospec.args[i]); if (ret)
if (ret) return ERR_PTR(ret);
return ERR_PTR(ret);
}
gpiochip_find(&gg_data, of_gpiochip_find_and_xlate); gpiochip_find(&gg_data, of_gpiochip_find_and_xlate);
if (!gg_data.out_gpio) { if (!gg_data.out_gpio) {