p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

spi: spi-qcom-qspi: Fix remaining driver nits 

Address remaining comments from original driver patch series

* Move RD_FIFO_CFG to be ordered corretly
* Expand spinlock comment

Signed-off-by: Ryan Case <ryandcase@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Ryan Case 2018-10-22 18:07:07 -07:00 committed by Mark Brown
parent 1fc12b0589
commit 478652f3d4
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/spi/spi-qcom-qspi.c
View File

@ -90,6 +90,9 @@
#define PIO_DATAOUT_1B 0x0020 #define PIO_DATAOUT_1B 0x0020
#define PIO_DATAOUT_4B 0x0024 #define PIO_DATAOUT_4B 0x0024
#define RD_FIFO_CFG 0x0028
#define CONTINUOUS_MODE BIT(0)
#define RD_FIFO_STATUS 0x002c #define RD_FIFO_STATUS 0x002c
#define FIFO_EMPTY BIT(11) #define FIFO_EMPTY BIT(11)
#define WR_CNTS_MSK 0x7f0 #define WR_CNTS_MSK 0x7f0
@ -99,9 +102,6 @@
#define RDY_16BYTE BIT(1) #define RDY_16BYTE BIT(1)
#define FIFO_RDY BIT(0) #define FIFO_RDY BIT(0)
#define RD_FIFO_CFG 0x0028
#define CONTINUOUS_MODE BIT(0)
#define RD_FIFO_RESET 0x0030 #define RD_FIFO_RESET 0x0030
#define RESET_FIFO BIT(0) #define RESET_FIFO BIT(0)
@ -139,7 +139,7 @@ struct qcom_qspi {
struct device *dev; struct device *dev;
struct clk_bulk_data clks[QSPI_NUM_CLKS]; struct clk_bulk_data clks[QSPI_NUM_CLKS];
struct qspi_xfer xfer; struct qspi_xfer xfer;
/* Lock to protect data accessed by IRQs */ /* Lock to protect xfer and IRQ accessed registers */
spinlock_t lock; spinlock_t lock;
}; };