p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

rsi_91x: fix uninitialized variable 

There is a potential execution path in which variable ret is returned
without being properly initialized previously.

Fix this by storing the value returned by function
rsi_usb_master_reg_write into _ret_.

Addresses-Coverity-ID: 1468407 ("Uninitialized scalar variable")
Fixes: 16d3bb7b2f ("rsi: disable fw watchdog timer during reset")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
Gustavo A. R. Silva 2018-04-26 08:13:24 -05:00 committed by Kalle Valo
parent e1fd7ceec1
commit 48c6b5c9c1
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/wireless/rsi/rsi_91x_usb.c
View File

@ -687,9 +687,10 @@ static int rsi_reset_card(struct rsi_hw *adapter)
*/ */
msleep(100); msleep(100);
if (rsi_usb_master_reg_write(adapter, SWBL_REGOUT, ret = rsi_usb_master_reg_write(adapter, SWBL_REGOUT,
RSI_FW_WDT_DISABLE_REQ, RSI_FW_WDT_DISABLE_REQ,
RSI_COMMON_REG_SIZE) < 0) { RSI_COMMON_REG_SIZE);
if (ret < 0) {
rsi_dbg(ERR_ZONE, "Disabling firmware watchdog timer failed\n"); rsi_dbg(ERR_ZONE, "Disabling firmware watchdog timer failed\n");
goto fail; goto fail;
} }