p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

hwmon: (coretemp) Avoid redundant lookups 

No point in looking up the same thing over and over.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Thomas Gleixner 2016-11-22 17:42:03 +00:00 committed by Guenter Roeck
parent e1b370b640
commit 4b138cf73f
1 changed files with 6 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/hwmon/coretemp.c
View File

@ -533,21 +533,14 @@ static int create_core_data(struct platform_device *pdev, unsigned int cpu,
return err; return err;
} }
static void coretemp_add_core(unsigned int cpu, int pkg_flag) static void
coretemp_add_core(struct platform_device *pdev, unsigned int cpu, int pkg_flag)
{ {
struct platform_device *pdev = coretemp_get_pdev(cpu); if (create_core_data(pdev, cpu, pkg_flag))
int err;
if (!pdev)
return;
err = create_core_data(pdev, cpu, pkg_flag);
if (err)
dev_err(&pdev->dev, "Adding Core %u failed\n", cpu); dev_err(&pdev->dev, "Adding Core %u failed\n", cpu);
} }
static void coretemp_remove_core(struct platform_data *pdata, static void coretemp_remove_core(struct platform_data *pdata, int indx)
int indx)
{ {
struct temp_data *tdata = pdata->core_data[indx]; struct temp_data *tdata = pdata->core_data[indx];
@ -692,7 +685,7 @@ static void get_core_online(unsigned int cpu)
* If so, add interfaces for pkgtemp. * If so, add interfaces for pkgtemp.
*/ */
if (cpu_has(c, X86_FEATURE_PTS)) if (cpu_has(c, X86_FEATURE_PTS))
coretemp_add_core(cpu, 1); coretemp_add_core(pdev, cpu, 1);
} }
pdata = platform_get_drvdata(pdev); pdata = platform_get_drvdata(pdev);
@ -701,7 +694,7 @@ static void get_core_online(unsigned int cpu)
* interface for this CPU core. * interface for this CPU core.
*/ */
if (!cpumask_intersects(&pdata->cpumask, topology_sibling_cpumask(cpu))) if (!cpumask_intersects(&pdata->cpumask, topology_sibling_cpumask(cpu)))
coretemp_add_core(cpu, 0); coretemp_add_core(pdev, cpu, 0);
cpumask_set_cpu(cpu, &pdata->cpumask); cpumask_set_cpu(cpu, &pdata->cpumask);
} }