p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

xen: make use of xenbus_read_unsigned() in xen-pciback 

Use xenbus_read_unsigned() instead of xenbus_scanf() when possible.
This requires to change the type of the read from int to unsigned,
but this case has been wrong before: negative values are not allowed
for the modified case.

Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: David Vrabel <david.vrabel@citrix.com>
This commit is contained in:
Juergen Gross 2016-10-31 14:58:41 +01:00
parent eaf46e181e
commit 4e81f1caa7
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/xen/xen-pciback/xenbus.c
View File

@ -362,7 +362,7 @@ static int xen_pcibk_reconfigure(struct xen_pcibk_device *pdev)
int err = 0; int err = 0;
int num_devs; int num_devs;
int domain, bus, slot, func; int domain, bus, slot, func;
int substate; unsigned int substate;
int i, len; int i, len;
char state_str[64]; char state_str[64];
char dev_str[64]; char dev_str[64];
@ -395,10 +395,8 @@ static int xen_pcibk_reconfigure(struct xen_pcibk_device *pdev)
"configuration"); "configuration");
goto out; goto out;
} }
err = xenbus_scanf(XBT_NIL, pdev->xdev->nodename, state_str, substate = xenbus_read_unsigned(pdev->xdev->nodename, state_str,
"%d", &substate); XenbusStateUnknown);
if (err != 1)
substate = XenbusStateUnknown;
switch (substate) { switch (substate) {
case XenbusStateInitialising: case XenbusStateInitialising: