p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

isofs: fix potential memory leak in mount option parsing 

When specifying string type mount option (e.g., iocharset)
several times in a mount, current option parsing may
cause memory leak. Hence, call kfree for previous one
in this case. Meanwhile, check memory allocation result
for it.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Signed-off-by: Jan Kara <jack@suse.cz>
This commit is contained in:
Chengguang Xu 2018-04-14 20:16:06 +08:00 committed by Jan Kara
parent 96348e4936
commit 4f34a5130a
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/isofs/inode.c
View File

@ -394,7 +394,10 @@ static int parse_options(char *options, struct iso9660_options *popt)
break; break;
#ifdef CONFIG_JOLIET #ifdef CONFIG_JOLIET
case Opt_iocharset: case Opt_iocharset:
kfree(popt->iocharset);
popt->iocharset = match_strdup(&args[0]); popt->iocharset = match_strdup(&args[0]);
if (!popt->iocharset)
return 0;
break; break;
#endif #endif
case Opt_map_a: case Opt_map_a: