p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

sched/core: Fix regression in cpuset_cpu_inactive() for suspend 

Commit 3c18d447b3 ("sched/core: Check for available DL bandwidth in
cpuset_cpu_inactive()"), a SCHED_DEADLINE bugfix, had a logic error that
caused a regression in setting a CPU inactive during suspend. I ran into
this when a program was failing pthread_setaffinity_np() with EINVAL after
a suspend+wake up.

A simple reproducer:

	$ ./a.out
	sched_setaffinity: Success
	$ systemctl suspend
	$ ./a.out
	sched_setaffinity: Invalid argument

... where ./a.out is:

	#define _GNU_SOURCE
	#include <errno.h>
	#include <sched.h>
	#include <stdio.h>
	#include <stdlib.h>
	#include <string.h>
	#include <unistd.h>

	int main(void)
	{
		long num_cores;
		cpu_set_t cpu_set;
		int ret;

		num_cores = sysconf(_SC_NPROCESSORS_ONLN);
		CPU_ZERO(&cpu_set);
		CPU_SET(num_cores - 1, &cpu_set);
		errno = 0;
		ret = sched_setaffinity(getpid(), sizeof(cpu_set), &cpu_set);
		perror("sched_setaffinity");
		return ret ? EXIT_FAILURE : EXIT_SUCCESS;
	}

The mistake is that suspend is handled in the action ==
CPU_DOWN_PREPARE_FROZEN case of the switch statement in
cpuset_cpu_inactive().

However, the commit in question masked out CPU_TASKS_FROZEN
from the action, making this case dead.

The fix is straightforward.

Signed-off-by: Omar Sandoval <osandov@osandov.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Juri Lelli <juri.lelli@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 3c18d447b3 ("sched/core: Check for available DL bandwidth in cpuset_cpu_inactive()")
Link: http://lkml.kernel.org/r/1cb5ecb3d6543c38cce5790387f336f54ec8e2bc.1430733960.git.osandov@osandov.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
Omar Sandoval 2015-05-04 03:09:36 -07:00 committed by Ingo Molnar
parent 0782e63bc6
commit 533445c6e5
1 changed files with 12 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
kernel/sched/core.c
View File

@ -6999,27 +6999,23 @@ static int cpuset_cpu_inactive(struct notifier_block *nfb, unsigned long action,
unsigned long flags; unsigned long flags;
long cpu = (long)hcpu; long cpu = (long)hcpu;
struct dl_bw *dl_b; struct dl_bw *dl_b;
bool overflow;
int cpus;
switch (action & ~CPU_TASKS_FROZEN) { switch (action) {
case CPU_DOWN_PREPARE: case CPU_DOWN_PREPARE:
/* explicitly allow suspend */ rcu_read_lock_sched();
if (!(action & CPU_TASKS_FROZEN)) { dl_b = dl_bw_of(cpu);
bool overflow;
int cpus;
rcu_read_lock_sched(); raw_spin_lock_irqsave(&dl_b->lock, flags);
dl_b = dl_bw_of(cpu); cpus = dl_bw_cpus(cpu);
overflow = __dl_overflow(dl_b, cpus, 0, 0);
raw_spin_unlock_irqrestore(&dl_b->lock, flags);
raw_spin_lock_irqsave(&dl_b->lock, flags); rcu_read_unlock_sched();
cpus = dl_bw_cpus(cpu);
overflow = __dl_overflow(dl_b, cpus, 0, 0);
raw_spin_unlock_irqrestore(&dl_b->lock, flags);
rcu_read_unlock_sched(); if (overflow)
return notifier_from_errno(-EBUSY);
if (overflow)
return notifier_from_errno(-EBUSY);
}
cpuset_update_active_cpus(false); cpuset_update_active_cpus(false);
break; break;
case CPU_DOWN_PREPARE_FROZEN: case CPU_DOWN_PREPARE_FROZEN: