p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

mmc: mmc_test: Improve a size determination in five functions 

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
Markus Elfring 2017-01-08 21:25:44 +01:00 committed by Ulf Hansson
parent 7200449dc6
commit 554d7c540e
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/mmc/core/mmc_test.c
View File

@ -356,7 +356,7 @@ static struct mmc_test_mem *mmc_test_alloc_mem(unsigned long min_sz,
if (max_segs > max_page_cnt) if (max_segs > max_page_cnt)
max_segs = max_page_cnt; max_segs = max_page_cnt;
mem = kzalloc(sizeof(struct mmc_test_mem), GFP_KERNEL); mem = kzalloc(sizeof(*mem), GFP_KERNEL);
if (!mem) if (!mem)
return NULL; return NULL;
@ -545,7 +545,7 @@ static void mmc_test_save_transfer_result(struct mmc_test_card *test,
if (!test->gr) if (!test->gr)
return; return;
tr = kmalloc(sizeof(struct mmc_test_transfer_result), GFP_KERNEL); tr = kmalloc(sizeof(*tr), GFP_KERNEL);
if (!tr) if (!tr)
return; return;
@ -2973,8 +2973,7 @@ static void mmc_test_run(struct mmc_test_card *test, int testcase)
} }
} }
gr = kzalloc(sizeof(struct mmc_test_general_result), gr = kzalloc(sizeof(*gr), GFP_KERNEL);
GFP_KERNEL);
if (gr) { if (gr) {
INIT_LIST_HEAD(&gr->tr_lst); INIT_LIST_HEAD(&gr->tr_lst);
@ -3108,7 +3107,7 @@ static ssize_t mtf_test_write(struct file *file, const char __user *buf,
if (ret) if (ret)
return ret; return ret;
test = kzalloc(sizeof(struct mmc_test_card), GFP_KERNEL); test = kzalloc(sizeof(*test), GFP_KERNEL);
if (!test) if (!test)
return -ENOMEM; return -ENOMEM;
@ -3213,7 +3212,7 @@ static int __mmc_test_register_dbgfs_file(struct mmc_card *card,
return -ENODEV; return -ENODEV;
} }
df = kmalloc(sizeof(struct mmc_test_dbgfs_file), GFP_KERNEL); df = kmalloc(sizeof(*df), GFP_KERNEL);
if (!df) { if (!df) {
debugfs_remove(file); debugfs_remove(file);
dev_err(&card->dev, dev_err(&card->dev,