p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

memory: tegra: mc: Add missing of_node_put() 

for_each_child_of_node() performs an of_node_get() on each iteration, so
to break out of the loop an of_node_put() is required.

Found using Coccinelle. The semantic patch used for this is as follows:

// <smpl>
@@
expression e;
local idexpression n;
@@

 for_each_child_of_node(..., n) {
   ... when != of_node_put(n)
       when != e = n
(
   return n;
|
+  of_node_put(n);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
This commit is contained in:
Amitoj Kaur Chawla 2016-01-25 22:53:07 +05:30 committed by Thierry Reding
parent d1122e4b76
commit 55bb1d8355
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/memory/tegra/mc.c
View File

@ -186,9 +186,11 @@ static int load_timings(struct tegra_mc *mc, struct device_node *node)
timing = &mc->timings[i++];
err = load_one_timing(mc, timing, child);
if (err)
if (err) {
of_node_put(child);
return err;
}
}
return 0;
}
@ -210,9 +212,9 @@ static int tegra_mc_setup_timings(struct tegra_mc *mc)
continue;
err = load_timings(mc, node);
of_node_put(node);
if (err)
return err;
of_node_put(node);
break;
}