p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

drm/omap: Remove omap_dss_device dst field 

The field is only used in a safety check during device
connection/disconnection, where the src field can be easily used
instead. Remove it and use src.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Tested-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
Laurent Pinchart 2018-09-12 19:05:18 +03:00 committed by Tomi Valkeinen
parent 19b4200d8f
commit 56c9818d5c
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/gpu/drm/omapdrm/dss/base.c
View File

@ -199,9 +199,8 @@ int omapdss_device_connect(struct dss_device *dss,
}
if (src) {
WARN_ON(src->dst);
WARN_ON(dst->src);
dst->src = src;
src->dst = dst;
}
return 0;
@ -219,11 +218,10 @@ void omapdss_device_disconnect(struct omap_dss_device *src,
}
if (src) {
if (WARN_ON(dst != src->dst))
if (WARN_ON(dst->src != src))
return;
dst->src = NULL;
src->dst = NULL;
}
WARN_ON(dst->state != OMAP_DSS_DISPLAY_DISABLED);

1
drivers/gpu/drm/omapdrm/dss/omapdss.h
View File

@ -406,7 +406,6 @@ struct omap_dss_device {
struct dss_device *dss;
struct omap_dss_device *src;
struct omap_dss_device *dst;
struct omap_dss_device *next;
struct list_head list;