p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

staging: comedi: ni_tio: remove some dead code 

These conditions can never be true because "i" is always one more than
NI_660X_MAX_RTSI_CHAN after the loop.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2014-07-31 12:29:18 +03:00 committed by Greg Kroah-Hartman
parent 1a4493c555
commit 578dc59f20
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/staging/comedi/drivers/ni_tio.c
View File

@ -1012,14 +1012,10 @@ static unsigned ni_660x_gate_to_generic_gate(unsigned gate)
if (gate == NI_660X_RTSI_GATE_SEL(i)) if (gate == NI_660X_RTSI_GATE_SEL(i))
return NI_GPCT_RTSI_GATE_SELECT(i); return NI_GPCT_RTSI_GATE_SELECT(i);
} }
if (i <= NI_660X_MAX_RTSI_CHAN)
break;
for (i = 0; i <= NI_660X_MAX_GATE_PIN; ++i) { for (i = 0; i <= NI_660X_MAX_GATE_PIN; ++i) {
if (gate == NI_660X_PIN_GATE_SEL(i)) if (gate == NI_660X_PIN_GATE_SEL(i))
return NI_GPCT_GATE_PIN_GATE_SELECT(i); return NI_GPCT_GATE_PIN_GATE_SELECT(i);
} }
if (i <= NI_660X_MAX_GATE_PIN)
break;
BUG(); BUG();
break; break;
} }
@ -1052,14 +1048,10 @@ static unsigned ni_m_gate_to_generic_gate(unsigned gate)
if (gate == NI_M_RTSI_GATE_SEL(i)) if (gate == NI_M_RTSI_GATE_SEL(i))
return NI_GPCT_RTSI_GATE_SELECT(i); return NI_GPCT_RTSI_GATE_SELECT(i);
} }
if (i <= NI_M_MAX_RTSI_CHAN)
break;
for (i = 0; i <= NI_M_MAX_PFI_CHAN; ++i) { for (i = 0; i <= NI_M_MAX_PFI_CHAN; ++i) {
if (gate == NI_M_PFI_GATE_SEL(i)) if (gate == NI_M_PFI_GATE_SEL(i))
return NI_GPCT_PFI_GATE_SELECT(i); return NI_GPCT_PFI_GATE_SELECT(i);
} }
if (i <= NI_M_MAX_PFI_CHAN)
break;
BUG(); BUG();
break; break;
} }
@ -1088,14 +1080,10 @@ static unsigned ni_660x_gate2_to_generic_gate(unsigned gate)
if (gate == NI_660X_RTSI_GATE2_SEL(i)) if (gate == NI_660X_RTSI_GATE2_SEL(i))
return NI_GPCT_RTSI_GATE_SELECT(i); return NI_GPCT_RTSI_GATE_SELECT(i);
} }
if (i <= NI_660X_MAX_RTSI_CHAN)
break;
for (i = 0; i <= NI_660X_MAX_UP_DOWN_PIN; ++i) { for (i = 0; i <= NI_660X_MAX_UP_DOWN_PIN; ++i) {
if (gate == NI_660X_UD_PIN_GATE2_SEL(i)) if (gate == NI_660X_UD_PIN_GATE2_SEL(i))
return NI_GPCT_UP_DOWN_PIN_GATE_SELECT(i); return NI_GPCT_UP_DOWN_PIN_GATE_SELECT(i);
} }
if (i <= NI_660X_MAX_UP_DOWN_PIN)
break;
BUG(); BUG();
break; break;
} }