p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "tick: Prefer a lower rating device only if it's CPU local device" 

This reverts commit 1332a90558.

The original issue was not because of incorrect checking of cpumask for
both new and old tick device. It was incorrectly analysed was due to the
misunderstanding of the comment and misinterpretation of the return value
from tick_check_preferred. The main issue is with the clockevent driver
that sets the cpumask to cpu_all_mask instead of cpu_possible_mask.

Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: Marc Zyngier <marc.zyngier@arm.com>
Link: https://lkml.kernel.org/r/1531151136-18297-1-git-send-email-sudeep.holla@arm.com
This commit is contained in:
Sudeep Holla 2018-07-09 16:45:35 +01:00 committed by Thomas Gleixner
parent 1e4b044d22
commit 5b5ccbc2b0
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
kernel/time/tick-common.c
View File

@ -277,8 +277,7 @@ static bool tick_check_preferred(struct clock_event_device *curdev,
*/ */
return !curdev || return !curdev ||
newdev->rating > curdev->rating || newdev->rating > curdev->rating ||
(!cpumask_equal(curdev->cpumask, newdev->cpumask) && !cpumask_equal(curdev->cpumask, newdev->cpumask);
!tick_check_percpu(curdev, newdev, smp_processor_id()));
} }
/* /*