p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

gpio: em: use BIT() macro instead of shifting bits 

Using the BIT() macro instead of shifting bits
makes the code less error prone and also more readable.

Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Javier Martinez Canillas 2014-04-27 02:00:47 +02:00 committed by Linus Walleij
parent f9748ef13b
commit 5f077644b9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpio/gpio-em.c
View File

@ -212,7 +212,7 @@ static void __em_gio_set(struct gpio_chip *chip, unsigned int reg,
{ {
/* upper 16 bits contains mask and lower 16 actual value */ /* upper 16 bits contains mask and lower 16 actual value */
em_gio_write(gpio_to_priv(chip), reg, em_gio_write(gpio_to_priv(chip), reg,
(1 << (shift + 16)) | (value << shift)); (BIT(shift + 16)) | (value << shift));
} }
static void em_gio_set(struct gpio_chip *chip, unsigned offset, int value) static void em_gio_set(struct gpio_chip *chip, unsigned offset, int value)