p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net: atm: Reduce the severity of logging in unlink_clip_vcc 

In case of errors in unlink_clip_vcc, the logging level is set to
pr_crit but failures in clip_setentry are handled by pr_err().
The patch changes the severity consistent across invocations.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Aditya Pakki 2019-11-17 14:28:36 -06:00 committed by David S. Miller
parent 34e5983656
commit 60f5c4aaae
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
net/atm/clip.c
View File

@ -89,7 +89,7 @@ static void unlink_clip_vcc(struct clip_vcc *clip_vcc)
struct clip_vcc **walk; struct clip_vcc **walk;
if (!entry) { if (!entry) {
pr_crit("!clip_vcc->entry (clip_vcc %p)\n", clip_vcc); pr_err("!clip_vcc->entry (clip_vcc %p)\n", clip_vcc);
return; return;
} }
netif_tx_lock_bh(entry->neigh->dev); /* block clip_start_xmit() */ netif_tx_lock_bh(entry->neigh->dev); /* block clip_start_xmit() */
@ -109,10 +109,10 @@ static void unlink_clip_vcc(struct clip_vcc *clip_vcc)
error = neigh_update(entry->neigh, NULL, NUD_NONE, error = neigh_update(entry->neigh, NULL, NUD_NONE,
NEIGH_UPDATE_F_ADMIN, 0); NEIGH_UPDATE_F_ADMIN, 0);
if (error) if (error)
pr_crit("neigh_update failed with %d\n", error); pr_err("neigh_update failed with %d\n", error);
goto out; goto out;
} }
pr_crit("ATMARP: failed (entry %p, vcc 0x%p)\n", entry, clip_vcc); pr_err("ATMARP: failed (entry %p, vcc 0x%p)\n", entry, clip_vcc);
out: out:
netif_tx_unlock_bh(entry->neigh->dev); netif_tx_unlock_bh(entry->neigh->dev);
} }