p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

block: Cleanup elevator_init_mq() use 

Instead of checking a queue tag_set BLK_MQ_F_NO_SCHED flag before
calling elevator_init_mq() to make sure that the queue supports IO
scheduling, use the elevator.c function elv_support_iosched() in
elevator_init_mq(). This does not introduce any functional change but
ensure that elevator_init_mq() does the right thing based on the queue
settings.

Reviewed-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Damien Le Moal 2019-09-05 18:51:29 +09:00 committed by Jens Axboe
parent 362cd2b1fa
commit 61db437d1c
2 changed files with 16 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
block/blk-mq.c
View File

@ -2910,11 +2910,9 @@ struct request_queue *blk_mq_init_allocated_queue(struct blk_mq_tag_set *set,
blk_mq_add_queue_tag_set(set, q); blk_mq_add_queue_tag_set(set, q);
blk_mq_map_swqueue(q); blk_mq_map_swqueue(q);
if (!(set->flags & BLK_MQ_F_NO_SCHED)) { ret = elevator_init_mq(q);
ret = elevator_init_mq(q); if (ret)
if (ret) goto err_tag_set;
goto err_tag_set;
}
return q; return q;

23
block/elevator.c
View File

@ -619,16 +619,26 @@ int elevator_switch_mq(struct request_queue *q,
return ret; return ret;
} }
static inline bool elv_support_iosched(struct request_queue *q)
{
if (q->tag_set && (q->tag_set->flags & BLK_MQ_F_NO_SCHED))
return false;
return true;
}
/* /*
* For blk-mq devices, we default to using mq-deadline, if available, for single * For blk-mq devices supporting IO scheduling, we default to using mq-deadline,
* queue devices. If deadline isn't available OR we have multiple queues, * if available, for single queue devices. If deadline isn't available OR we
* default to "none". * have multiple queues, default to "none".
*/ */
int elevator_init_mq(struct request_queue *q) int elevator_init_mq(struct request_queue *q)
{ {
struct elevator_type *e; struct elevator_type *e;
int err = 0; int err = 0;
if (!elv_support_iosched(q))
return 0;
if (q->nr_hw_queues != 1) if (q->nr_hw_queues != 1)
return 0; return 0;
@ -706,13 +716,6 @@ static int __elevator_change(struct request_queue *q, const char *name)
return elevator_switch(q, e); return elevator_switch(q, e);
} }
static inline bool elv_support_iosched(struct request_queue *q)
{
if (q->tag_set && (q->tag_set->flags & BLK_MQ_F_NO_SCHED))
return false;
return true;
}
ssize_t elv_iosched_store(struct request_queue *q, const char *name, ssize_t elv_iosched_store(struct request_queue *q, const char *name,
size_t count) size_t count)
{ {